aherbert commented on code in PR #217:
URL: https://github.com/apache/commons-math/pull/217#discussion_r1002382575
##########
commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ml/clustering/ClusterEvaluator.java:
##########
@@ -50,6 +50,6 @@ public interface ClusterEvaluator {
static <T extends Clusterable> ClusterRanking ranking(ClusterEvaluator
eval) {
return eval.isBetterScore(1, 2) ?
clusters -> 1 / eval.score(clusters) :
- clusters -> eval.score(clusters);
+ eval::score;
Review Comment:
This has incorrect indentation
##########
commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/fitting/SimpleCurveFitter.java:
##########
@@ -319,7 +318,7 @@ private boolean isBetween(double value,
double boundary1,
double boundary2) {
return (value >= boundary1 && value <= boundary2) ||
- (value >= boundary2 && value <= boundary1);
+ (value >= boundary2 && value <= boundary1);
Review Comment:
Please revert the indentation too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
