[ 
https://issues.apache.org/jira/browse/LOGGING-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624889#comment-17624889
 ] 

Björn Heinrichs commented on LOGGING-183:
-----------------------------------------

I'd just like to add a small update to my Progress: I've added both changes and 
ran the tests using a private github repository. I'll be publishing the changes 
as an PR soon, but i have a feeling the maven build does not truely test 
anything. Unfortunately both clirr and japicmp seem to have issues running with 
code compiled in Java 9 (Clirr simple does not understand it). This should not 
be an issue though, as the module-info.class is only read by a JDK >= 9.

 

Unfortunately i've yet to see a way to disable that, as clirr uses the class 
name for checks, which requires successful reading of the class file. 

I'll try to move it to a fork as soon as i manage to get some free time :)

> Running Tests under Windows seems not to work properly.
> -------------------------------------------------------
>
>                 Key: LOGGING-183
>                 URL: https://issues.apache.org/jira/browse/LOGGING-183
>             Project: Commons Logging
>          Issue Type: Bug
>    Affects Versions: Nightly Builds
>         Environment: Windows 10 Enterprise
>  
> Tested under
> Java Version 1.8 and 11 (Both Corretto)
>            Reporter: Björn Heinrichs
>            Priority: Minor
>         Attachments: fix.patch, log-build.txt, log-test.txt, mvn.txt
>
>
> I've been trying to fork and contribute to commons logging to make it 
> compatible with the JPMS System. A related Issue is 
> https://issues.apache.org/jira/browse/COMMONSSITE-103
>  
> I've hit a couple of roadblocks though, as by default cloning the repository, 
> running mvn and then ant does not work.
>  
> In particular javadoc throws this (seemingly) unrelated error, even though 
> i've used both java 8 and Java 11 as the JDK.
> expected heading used: <H2>, compared to implicit preceding heading: <H3>
>  
> Removing it from the default goal helped though. As i did not plan to add any 
> javadocs anyway, i moved on to the next road block:
> Running Tests does not seem to work properly. I've attached two attempts to 
> run ant test. using both build.xml and build-test.xml in both configurations. 
> Unfortunately i will not be able to test under Java 2 for the forseeable 
> future.
>  
> In Github this does not seem to be an issue though. Searching through Jira, 
> Google and the logging site did not reveal any helpful information in regards 
> to building.
>  
> I also noticed that the getlibs is not working in build-testing.xml a 
> corresponding patch is attached.
>  
> As far as i can see it, i've done everything as intended. I appologize if 
> this is something more suited for the Mailing List, but to me it seems likely 
> to be a bug.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to