Claudenw commented on PR #335: URL: https://github.com/apache/commons-collections/pull/335#issuecomment-1295877575
In all cases where `AS_ARRAY_ORDERED` is set `FOR_EACH_ORDERED` is also set, and the `FOR_EACH_COUNT_ORDERED` is therefore set as well. In all cases where `AS_ARRAY_DISTINCT` is set `FOR_EACH_DISTINCT` is also set, and the `FOR_EACH_COUNT_DISTINCT` is therefore set as well. I propose collapsing this into 2 statics: `INDICES_ORDERED` : replaces `AS_ARRAY_ORDERED`, `FOR_EACH_ORDERED`, and `FOR_EACH_COUNT_ORDERED`. `INDICES_DISTINCT`: replaces `AS_ARRAY_DISTINCT`, `FOR_EACH_DISTINCT` and `FOR_EACH_COUNT_DISTINCT`. By "replaces" I mean remove all instances of the replaced constants (not make them equivalent). Add documentation that states the testing assumes the ORDERED and DISTINCT properties carry across `asArray()`, `forEachIndex()` and `forEachCount()`. Also, since the `AbstractBitCountProducerTest ` extends `AbstractIndexProducerTest` we can remove all `IndexProducerFrom_X_Test` implementations where there is a `BitCountProducerFrom_X_Test` @aherbert unless you have an objection, I'll proceed with these changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
