[ 
https://issues.apache.org/jira/browse/NUMBERS-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627239#comment-17627239
 ] 

Alex Herbert commented on NUMBERS-29:
-------------------------------------

{quote} In which other cases, do we add the Numbers suffix?
{quote}
None. I've updated to Stirling.

I have made a port of this method into the combinatorics module. I updated the 
recursion algorithm to perform a forward computation from the largest easily 
computed number. This solves the issue with stack overflow in the S(n, n-3) 
case. Using backward recursion can result in a call stack of 2738 for S(2762, 
2759). Using forward recursion has a maximum depth of 2 for this case. The 
largest call stack in the test data is for S(33, 23) with a depth of 10. 
Typically bad cases will raise an arithmetic exception due to overflow of the 
sum before the recursion depth is too high.

PR is here for review [PR 
126|https://github.com/apache/commons-numbers/pull/126].

 

> Move combinatorics utilities from "Commons Math"
> ------------------------------------------------
>
>                 Key: NUMBERS-29
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-29
>             Project: Commons Numbers
>          Issue Type: Task
>          Components: combinatorics
>            Reporter: Gilles Sadowski
>            Priority: Minor
>              Labels: module, move
>             Fix For: 1.2
>
>
> Create a new {{commons-numbers-combinatorics}} module to contain the code in 
> classes {{CombinatoricsUtils}} and {{Combinations}} (located in package 
> {{o.a.c.math4.util}}).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to