Claudenw commented on code in PR #357:
URL:
https://github.com/apache/commons-collections/pull/357#discussion_r1015756682
##########
src/test/java/org/apache/commons/collections4/bloomfilter/AbstractHasherTest.java:
##########
@@ -85,4 +86,7 @@ public void testHashing(int k, int m) {
});
assertEquals(1, count[0], "did not exit early");
}
+
+ @Test
+ public abstract void testIsEmpty();
Review Comment:
changed
##########
src/main/java/org/apache/commons/collections4/bloomfilter/Hasher.java:
##########
@@ -61,4 +61,10 @@ default IndexProducer uniqueIndices(Shape shape) {
return
Hasher.this.indices(shape).forEachIndex(IndexFilter.create(shape, consumer));
};
}
+
+ /**
+ * Returns {@code true} if the hasher is empty and will return no values.
+ * @return {@code true} if the hasher is empty and will return no values.
+ */
+ boolean isEmpty();
Review Comment:
changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
