Claudenw commented on code in PR #358:
URL:
https://github.com/apache/commons-collections/pull/358#discussion_r1032798849
##########
src/main/java/org/apache/commons/collections4/bloomfilter/BloomFilter.java:
##########
@@ -302,7 +302,7 @@ default int estimateIntersection(final BloomFilter other) {
if (Double.isInfinite(eUnion)) {
throw new IllegalArgumentException("The estimated N for the
union of the filters is infinite");
}
- // all estimated values are small values greater than 0 but less
that number of bits
+ // maximum estimate value using integer valuess is: 46144189292
Review Comment:
The note here is that an overflow of the addition is not possible. I
updated the comment. again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
