garydgregory commented on code in PR #178:
URL: https://github.com/apache/commons-bcel/pull/178#discussion_r1036422816
##########
src/test/java/org/apache/bcel/verifier/VerifierTestCase.java:
##########
@@ -126,6 +126,16 @@ public void testDefinitionImpl() throws
ClassNotFoundException {
testNestHostWithJavaVersion("com.ibm.wsdl.DefinitionImpl");
}
+ @Test
+ public void testJvmOpCodes() throws ClassNotFoundException {
+
testDefaultMethodValidation("org.apache.bcel.verifier.tests.JvmOpCodes");
+ }
+
+ @Test
+ public void testObjectBrowser() throws ClassNotFoundException {
+ testDefaultMethodValidation("groovy.inspect.swingui.ObjectBrowser");
// contains SWAP instruction
Review Comment:
This is not maintainable IMO because it's too easy to update Groovy and
loose whatever this test thinks it's testing. If you want to test a specific
instruction, add a class file and test that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
