[
https://issues.apache.org/jira/browse/COMPRESS-633?focusedWorklogId=830652&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-830652
]
ASF GitHub Bot logged work on COMPRESS-633:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Dec/22 14:05
Start Date: 02/Dec/22 14:05
Worklog Time Spent: 10m
Work Description: garydgregory commented on code in PR #332:
URL: https://github.com/apache/commons-compress/pull/332#discussion_r1038175628
##########
src/main/java/org/apache/commons/compress/utils/ByteUtils.java:
##########
@@ -266,4 +270,24 @@ private static void checkReadLength(final int length) {
throw new IllegalArgumentException("Can't read more than eight
bytes into a long value");
}
}
+
Review Comment:
It looks like this method is only used from the `sevenz` package so let's
keep it package-private there and avoid increasing the public API surface.
Issue Time Tracking
-------------------
Worklog Id: (was: 830652)
Time Spent: 50m (was: 40m)
> Adding support for SevenZ password encryption
> ---------------------------------------------
>
> Key: COMPRESS-633
> URL: https://issues.apache.org/jira/browse/COMPRESS-633
> Project: Commons Compress
> Issue Type: Improvement
> Components: Compressors
> Affects Versions: 1.22
> Reporter: Daniel Santos
> Priority: Major
> Labels: contributing, features
> Time Spent: 50m
> Remaining Estimate: 0h
>
> 👉🏼 The purpose is to provide password based encryption for 7z compression in
> the same way of decryption already supported, so go forward of [one know
> limitation|https://commons.apache.org/proper/commons-compress/limitations.html]
> ☝️In this way, I would like to submit my contribution based on the existing
> implementation of decryption and the [C++ implementation of 7z
> |https://github.com/kornelski/7z/blob/main/CPP/7zip/Crypto/7zAes.cpp]
> ✅ I added one unit test
>
> I prepared a [Pull Request on
> GitHub|https://github.com/apache/commons-compress/pull/332]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
