[
https://issues.apache.org/jira/browse/IO-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Wooten updated IO-229:
------------------------------
Attachment: varargs-and-or-filters.patch
This patch was generated using Eclipse. The patch replaces the
AndFileFilter(IOFileFilter, IOFileFilter) constructor with a
AndFileFilter(IOFileFilter...) one, and likewise for OrFileFilter. The utility
methods in FileFilterUtils have also been updated to accept a variable number
of arguments. Minor changes were made to the test cases to test accepting more
than two arguments.
> Convert AndFileFilter and OrFileFilter Constructors to Use Varargs
> ------------------------------------------------------------------
>
> Key: IO-229
> URL: https://issues.apache.org/jira/browse/IO-229
> Project: Commons IO
> Issue Type: Improvement
> Components: Filters
> Affects Versions: 2.0
> Environment: Java 1.5+
> Reporter: Michael Wooten
> Priority: Minor
> Fix For: 2.0
>
> Attachments: varargs-and-or-filters.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> I suggest converting the AndFileFilter(IOFileFilter filter1, IOFileFilter
> filter2) and OrFileFilter(IOFileFilter filter1, IOFileFilter filter2)
> constructors to use varargs and instead have the signatures
> AndFileFilter(IOFileFilter... filters) and OrFileFilter(IOFileFilter...
> filters). The benefit is that new And/OrFileFilters could be created without
> having to create a list or limit the initial number of filters to two.
> Ex:
> IOFileFilter hiddenNonEmptyTextFileFilter = new
> AndFileFilter(HiddenFileFilter.HIDDEN, EmptyFileFilter.NOT_EMPTY, new
> SuffixFileFilter(".txt"));
> If backwards compatibility is an issue, then the varargs constructors could
> be added alongside the two argument constructors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
