garydgregory commented on code in PR #344:
URL: https://github.com/apache/commons-compress/pull/344#discussion_r1057339000
##########
src/test/java/org/apache/commons/compress/harmony/pack200/tests/ArchiveTest.java:
##########
@@ -25,20 +28,27 @@
import java.io.InputStreamReader;
import java.io.OutputStream;
import java.net.URISyntaxException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
import java.util.Enumeration;
import java.util.jar.JarEntry;
import java.util.jar.JarFile;
import java.util.jar.JarInputStream;
import java.util.jar.JarOutputStream;
+import java.util.stream.Stream;
import org.apache.commons.compress.harmony.pack200.Archive;
import org.apache.commons.compress.harmony.pack200.Pack200Exception;
import org.apache.commons.compress.harmony.pack200.PackingOptions;
import org.apache.commons.compress.harmony.unpack200.Segment;
-import junit.framework.TestCase;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
-public class ArchiveTest extends TestCase {
+class ArchiveTest {
Review Comment:
There is no need to change the visibility of elements, it just overloads the
PR with noise for no gain. Yes, I know that JUnit 5 like this style, but that
is not the style we use in most if not all of Conmons components. It just make
the PR harder and longer to review. What matters is the use of the Junit API,
not the style IMO. For my money, the fact that a test is public tells me it's
important, not some internal gadget, so let's not change access unless required
(which should not happen).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
