garydgregory commented on code in PR #295:
URL: https://github.com/apache/commons-csv/pull/295#discussion_r1061861827
##########
src/main/java/org/apache/commons/csv/CSVFormat.java:
##########
@@ -288,6 +294,18 @@ public Builder setAllowDuplicateHeaderNames(final boolean
allowDuplicateHeaderNa
return this;
}
+ /**
+ * Sets whether the last field on the last line, if quoted, can have
no closing quote when the file ends, {@code true} if this is ok,
+ * {@code false} if {@link IOException} should be thrown.
+ *
+ * @param allowEOFWithoutClosingQuote whether to allow the last field
on the last line to have a missing closing quote when the file ends,
+ * {@code true} if so, or {@code
false} to cause an {@link IOException} to be thrown.
+ */
Review Comment:
Add Javadoc since tags to new public and protected elements.
##########
src/main/java/org/apache/commons/csv/CSVFormat.java:
##########
@@ -206,8 +206,12 @@ public static Builder create(final CSVFormat csvFormat) {
return new Builder(csvFormat);
}
+ private boolean allowEOFWithoutClosingQuote;
Review Comment:
Always use camel case allowEOFWithoutClosingQuote ->
allowEofWithoutClosingQuote
##########
src/main/java/org/apache/commons/csv/CSVFormat.java:
##########
@@ -1503,6 +1544,15 @@ public boolean getAllowDuplicateHeaderNames() {
return duplicateHeaderMode == DuplicateHeaderMode.ALLOW_ALL;
}
+ /**
+ * Gets whether the file can end before the last field on the last line,
if quoted, has a closing quote.
+ *
+ * @return {@code true} if so, {@code false} to throw an {@link
IOException}.
+ */
Review Comment:
Camel case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
