[
https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684354#comment-17684354
]
Matt Juntunen commented on GEOMETRY-144:
----------------------------------------
[~agoss], I've looked over your PR and it's looking good. I would like to see
more unit tests, particularly in the areas of asserting the expected output
vertices, checking that the algorithm is not sensitive to the order of the
input points, and testing cases where input points are very close to each other
wrt the configured precision. Before, we get there, though, I believe we first
need to come to a consensus on the public API we want. Your suggestion of doing
away with the {{ConvexHull3D}} interface and just using {{ConvexVolume}} got me
thinking more about what is actually needed here. My primary use case for
convex hull generation is during mesh manipulation. For example, you have a set
of geometries in mesh form and you want to compute the convex hull of all of
them together. This is a major reason I'm hesitant to use {{ConvexVolume}}: the
mesh form of the hull is generated directly in the algorithm and if that is the
desired end product, then converting to a {{ConvexVolume}} is just wasted work.
What, then, do you think of using {{Mesh}} as the end product of convex hull
operations? This would fulfill the requirement for easy access to vertex and
face information as well as allowing hulls of zero size, as in the case where
all points lie in the same plane. If needed, the caller can easily convert the
{{Mesh}} instance into {{ConvexVolume}} or {{RegionBSPTree3D}}.
> Review API in "hull" module
> ---------------------------
>
> Key: GEOMETRY-144
> URL: https://issues.apache.org/jira/browse/GEOMETRY-144
> Project: Commons Geometry
> Issue Type: Task
> Reporter: Gilles Sadowski
> Assignee: Gilles Sadowski
> Priority: Minor
> Fix For: 1.1
>
>
> Review codes in the
> [{{commons-geometry-hull}}|https://gitbox.apache.org/repos/asf?p=commons-geometry.git;a=tree;f=commons-geometry-hull;hb=HEAD]
> module.
> (x) Minimize the public API
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
