HiuKwok commented on PR #135: URL: https://github.com/apache/commons-email/pull/135#issuecomment-1419113353
@garydgregory Can you also advise on how unit can be written in this case? As this is a performance improvement rather than a bug fix, hence this is no change of behavior from an external perspective I can assert. I'm thinking to create a huge `.eml` file with an attachment in order to trigger an OOM exception as the original approach will load the whole file into the memory, which the revised method only loads a portion of the file into the input stream. But I don't think that makes sense to push a huge `.eml` under the test resources folder either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
