kinow commented on code in PR #271:
URL: https://github.com/apache/commons-imaging/pull/271#discussion_r1097858476
##########
src/test/java/org/apache/commons/imaging/formats/bmp/BmpRoundtripTest.java:
##########
@@ -140,17 +139,21 @@ private void writeAndReadImageData(final int[][] rawData)
throws IOException, Im
final byte[] bytes = Imaging.writeImageToBytes(srcImage,
ImageFormats.BMP);
- final File tempFile = Files.createTempFile("temp", ".bmp").toFile();
- FileUtils.writeByteArrayToFile(tempFile, bytes);
-
final BufferedImage dstImage = Imaging.getBufferedImage(bytes);
- assertNotNull(dstImage);
- assertEquals(srcImage.getWidth(), dstImage.getWidth());
- assertEquals(srcImage.getHeight(), dstImage.getHeight());
-
- final int[][] dstData = bufferedImageToImageData(dstImage);
- compare(rawData, dstData);
+ try {
+ assertNotNull(dstImage);
+ assertEquals(srcImage.getWidth(), dstImage.getWidth());
+ assertEquals(srcImage.getHeight(), dstImage.getHeight());
+
+ final int[][] dstData = bufferedImageToImageData(dstImage);
+ compare(rawData, dstData);
+ } catch (final Throwable e) {
+ final Path tempFile = Files.createTempFile("temp", ".bmp");
+ Files.write(tempFile, bytes);
+ System.err.println("Failed tempFile " + tempFile);
Review Comment:
(and no need to worry, I can undo the change to always write to disk if we
decide to go down that path :wink: :+1: )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
