thecarlhall commented on PR #180: URL: https://github.com/apache/commons-dbutils/pull/180#issuecomment-1429013372
Hi, @cstmgl ! Would you please tell me more about what you're seeing that brought you to this change? Could you share any exceptions, error messages, or oddities you've seen? On first scan of the code and the API doc you shared, I don't understand what effect this PR has. I'm keying particularly on this statement from the javadoc, > If a property is indexed, then its entry in the result array belongs to the [IndexedPropertyDescriptor](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/java/beans/IndexedPropertyDescriptor.html) subclass of the [PropertyDescriptor](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/java/beans/PropertyDescriptor.html) class From this and the submitted code change, the caller outside of this method would still need to cast the property descriptor to `IndexedPropertyDescriptor`. This leaves me confused to what the suggested change does downstream. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
