sebbASF commented on PR #278: URL: https://github.com/apache/commons-imaging/pull/278#issuecomment-1435525628
I agree the change as currently proposed should not be applied. The array of icon types could potentially be a static constant, but it would still be a waste of a resource. IMO the proposed code is less readable. What really needs fixing is the analyser! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
