[ 
https://issues.apache.org/jira/browse/COMPRESS-588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary D. Gregory resolved COMPRESS-588.
--------------------------------------
    Resolution: Cannot Reproduce

The code is different today and the gitbox link does show whatever the issue 
was at the time this ticket was created.

> String comparison using == instead of .equals() in 
> SegmentConstantPoolArrayCache
> --------------------------------------------------------------------------------
>
>                 Key: COMPRESS-588
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-588
>             Project: Commons Compress
>          Issue Type: Bug
>    Affects Versions: 1.21
>         Environment: Veracode Static code analysis
>            Reporter: Haakon M
>            Priority: Minor
>
> Hi
> We use Commons Compress as a dependency in our application. Our static scan 
> tool picked up a String comparison in SegmentConstantPoolArray:61 using == 
> instead of .equals.
>  
> I had a quick look at the file in question, and it seems that you're trying 
> to actually check if the two objects are the same, and so are using == in the 
> correct manner. But I wasn't certain, so I'm making this issue anyways, just 
> to be sure.
>  
> The file and line in question:
> [https://gitbox.apache.org/repos/asf?p=commons-compress.git;a=blob;f=src/main/java/org/apache/commons/compress/harmony/unpack200/SegmentConstantPoolArrayCache.java;h=2f6a7f06f3fb8c8c57fd5875090c9624b767e681;hb=HEAD#l61]
>  
> Thanks



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to