samabcde commented on PR #391: URL: https://github.com/apache/commons-collections/pull/391#issuecomment-1519006362
> > > Complete all test classes API migration in one PR, hence BulkTest does not extend TestCase and we can use static import for all assert API. > > > > > > I think it'd be simpler to migrate that part first, or include that in this change? That way we would be sure that tests are passing with JUnit5 API, without running the risk of some JUnit4 API leaking into the tests and failing later when we change the rest of the code. > > Agreed. @garydgregory , @kinow updated as suggested, please kindly help to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
