samabcde commented on PR #324:
URL: https://github.com/apache/commons-csv/pull/324#issuecomment-1529312025
> @samabcde I was going to merge and close CSV-306, but I think this PR does
not fix CSV-306?
>
> I imported this branch into my IDE, and looked at
`src/site/xdoc/user-guide.xml`, and looking at the example code I started
searching for methods and opening to check for `@deprecated` tags.
>
> This line is also using `withHeader()`
>
> ```
> final CSVParser parser = new CSVParser(reader,
CSVFormat.EXCEL.withHeader());
> ```
>
> marked as deprecated
>
> ```
> * @deprecated Use {@link Builder#setHeader(Class)}
> ```
>
> Further down there's another one
>
> ```
> Iterable<CSVRecord> records = CSVFormat.RFC4180.withHeader("ID",
"CustomerNo", "Name").parse(in);
> ```
>
> I can merge this one and leave the JIRA issue open. Or if you'd like this
PR to resolve CSV-306, could you look at the rest of the user guide fixing
deprecated calls? Up to you 🙂
>
> Cheers Bruno
@kinow , thx for pointing out, let me fix that also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
