StefanOltmann commented on PR #275: URL: https://github.com/apache/commons-imaging/pull/275#issuecomment-1539231835
@garydgregory, I believe that the ExifRewriterRoundtripTest still requires some adjustments. Specifically, we need to ignore the offsets because they may have changed after reordering. The suggested addition of `length -= 1;` by @gwlucastrig is correct. Please find below another test photo:  Load and save the photo without making any changes, and then review the metadata using a viewer of your choice. You will notice that the copyright "CC-BY 3.0" has become ".C-BY 3.0" due to the bug. Additionally, other files may have been impacted, including camera and lens names, as well as other string types. It is easy to confirm the correctness of the fix without a unit test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
