Claudenw commented on code in PR #397:
URL:
https://github.com/apache/commons-collections/pull/397#discussion_r1227011235
##########
src/main/java/org/apache/commons/collections4/bloomfilter/BloomFilter.java:
##########
@@ -289,12 +289,12 @@ default int estimateIntersection(final BloomFilter other)
{
// if both are infinite the union is infinite and we return
Integer.MAX_VALUE
return Integer.MAX_VALUE;
}
- long estimate;
Review Comment:
>
I am working on a stable Bloom filter implementation -- I think I have it
working but I have a lot more checking to do. The implementation and
definition is based on
http://webdocs.cs.ualberta.ca/~drafiei/papers/DupDet06Sigmod.pdf
The stable Bloom filter is intended to be used in a streaming environment so
it disables some random bits before each item is added. The upshot is that
when the system attempts to turn on all the bits in the filter it will most
likely fail. So some tests do not function as for the normal Bloom filter.
If you are interested in looking at the code it can be found in
https://github.com/Claudenw/IdSupplier
I have proposed that Kafka use a stable Bloom filter to resolve one of the
issues they are working on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
