mawiesne commented on code in PR #394:
URL: https://github.com/apache/commons-compress/pull/394#discussion_r1232608392
##########
src/main/java/org/apache/commons/compress/harmony/unpack200/bytecode/forms/ClassRefForm.java:
##########
@@ -62,7 +62,7 @@ protected void setNestedEntries(final ByteCode byteCode,
final OperandManager op
// the spec except for multianewarray, which has
// its own form.)
final SegmentConstantPool globalPool =
operandManager.globalConstantPool();
- ClassFileEntry[] nested = null;
+ ClassFileEntry[] nested;
Review Comment:
> @mawiesne
>
> Why is this a standalone declaration and not assigned? IOW, why not
perform the assignment from the line below here? Same for the other files
changed.
Will check/optimize that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]