garydgregory commented on PR #127: URL: https://github.com/apache/commons-net/pull/127#issuecomment-1605570936
> We are facing the same problem connecting to FTP servers behind a squid proxy, any chance for a new release ? Hi @marwenlahmar, Finally coming back to these parts... I am not comfortable merging this PR unless there is a test that shows that it fixes something. No matter what IRL testing may have taken place. IOW, a test should fail without any change to the `main` tree. Then, when the `main` changes are applied, the test passes. This new test can be set up in any way you want, using plain unit testing, using mock objects, or even Docker (there is a Maven docker plugin). HTH, G -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
