[ 
https://issues.apache.org/jira/browse/IMAGING-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739371#comment-17739371
 ] 

Gary Lucas commented on IMAGING-356:
------------------------------------

No luck.   Same runtime as before...  Though the change did reduce the memory 
use quite a bit. 

First, to confirm that I tested the right thing... You pushed your changes 
directly to the master branch?  That's where I downloaded code and I did see 
the commit comment saying "Delegate size". I also stepped through the code just 
to be sure that a change was in effect.  The change I saw looks much more 
reasonable than the previous approach.

Did you try running the ApacheImagingSpeedAndMemoryTest?   I wrote it back when 
I was trying to optimize the speed of the imaging classes (the old Sanselan 
classes).  I tried a lot of different ideas before I got things running at a 
reasonable speed.  It was very helpful.  For this test, I tried processing the 
file called PICT2833.TIF which is included in the project distribution as part 
of a suite of test files.

Gary

P.S.  On an separate issue, have you been seeing complaints about encoding 
errors in the Allocator class?  I am seeing invalid UTF-8 characters in the 
Javadoc comments on lines 144 and 165.

> TIFF reading extremely slow in version 1.0-SNAPSHOT
> ---------------------------------------------------
>
>                 Key: IMAGING-356
>                 URL: https://issues.apache.org/jira/browse/IMAGING-356
>             Project: Commons Imaging
>          Issue Type: Bug
>          Components: Format: TIFF
>    Affects Versions: 1.0
>            Reporter: Gary Lucas
>            Priority: Major
>
> I am using the latest code from github (1.0-SNAPSHOT downloaded from github 
> of June 2023) to read a 300 megabyte TIFF file.  Version 1.0-alpha3 required 
> 673 milliseconds to read that file.  The new code requires upward of 15 
> minutes.   Clearly something got broken since the last release.
> The TIFF file is a 10000x10000 pixel 4 byte image format organized in strips. 
>  The bottleneck appears to occur in the TiffReader getTiffRawImageData method 
> which reads raw data from the file in preparation of creating a BufferedImage 
> object.
> I suspect that there may be a general slowness of file access.  In debugging, 
> even reading the initial metadata (22 TIFF tags) took a couple of seconds.  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to