garydgregory commented on code in PR #161:
URL: https://github.com/apache/commons-net/pull/161#discussion_r1249526432
##########
src/test/java/org/apache/commons/net/util/Base64Test.java:
##########
@@ -208,9 +241,10 @@ public void testEncodeObject() {
}
@Test
- @Ignore
public void testEncodeToString() {
- fail("Not yet implemented");
+ final Base64 base64 = new Base64();
+ final byte[] bytesToEncode = new byte[] {'l', 'i', 'g', 'h', 't', ' ',
'w', 'o', 'r'};
Review Comment:
> Random question here; was the example intended to be "light work" encoded?
🙂 Asking as it was used in the other tests, but doesn't really matter as this
test is working fine 👍
In the future, we could split up test method per test source, like
`testWikipediaExamplesAbc`, `testRfc123FeatureX`, and so on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
