garydgregory commented on PR #1075: URL: https://github.com/apache/commons-lang/pull/1075#issuecomment-1616683936
@orionlibs Thank you for your PR. -1: IMO, this is a case where you have to consider making it evident to people reading the code what it is we support. One method per processor type makes it obvious as soon as you look at the class. I would say that this is a rare case, where a tiny amount of code duplication (calling the ctor) is worth it because: The code is only invoked once (per class loader) and the method names serve as "code as documentation". Each private method _could_ have a Javadoc added to make it even nicer, but I'll leave that as a TODO for anyone that wants to do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
