Claudenw commented on code in PR #402: URL: https://github.com/apache/commons-collections/pull/402#discussion_r1253585469
########## src/main/java/org/apache/commons/collections4/bloomfilter/WrappedBloomFilter.java: ########## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.collections4.bloomfilter; + +import java.util.function.IntPredicate; +import java.util.function.LongPredicate; + +/** + * An abstract class to assist in implementing Bloom filter decorators. + * + * @since 4.5 + */ +public abstract class WrappedBloomFilter implements BloomFilter { Review Comment: Let's consider this for a moment. The example in the test code is precisely what the Kafka KIP-936 is looking for. Now, I don't want to implement a "strange" bloom filter in this class, but I do want an easy way to extend the classes we have. Since they are all final decorating them with a wrapper is the only reasonable solution. So let's provide the solution. If we move it out, then I will have to ask to move it back when the KIP-936 begins development using this library. I believe they are starting that process now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
