[
https://issues.apache.org/jira/browse/GEOMETRY-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743154#comment-17743154
]
Alex Herbert commented on GEOMETRY-150:
---------------------------------------
Infra now requires that all PRs must be approved to run the actions. It used to
be only new contributors (i.e. a first PR). For security reasons this was
changed. I authorised it, and it failed as you pointed out for compatibility
reasons:
{noformat}
Error: Failed to execute goal
com.github.siom79.japicmp:japicmp-maven-plugin:0.17.2:cmp (default) on project
commons-geometry-core: There is at least one incompatibility:
org.apache.commons.geometry.core.internal.DistancedValue.ascendingDistance():CLASS_GENERIC_TEMPLATE_CHANGED,org.apache.commons.geometry.core.internal.DistancedValue.descendingDistance():CLASS_GENERIC_TEMPLATE_CHANGED,org.apache.commons.geometry.core.internal.DistancedValue.of(java.lang.Object,double):CLASS_GENERIC_TEMPLATE_CHANGED,org.apache.commons.geometry.core.internal.GeometryInternalUtils.requireFinite(org.apache.commons.geometry.core.Point):CLASS_GENERIC_TEMPLATE_CHANGED,org.apache.commons.geometry.core.Vector.isCodirectionalTo(org.apache.commons.geometry.core.Vector):METHOD_ADDED_TO_INTERFACE
-> [Help 1]{noformat}
Not a very helpful message but the key is the last code:
METHOD_ADDED_TO_INTERFACE
> implement isCodirectionalTo(Vector y)
> -------------------------------------
>
> Key: GEOMETRY-150
> URL: https://issues.apache.org/jira/browse/GEOMETRY-150
> Project: Commons Geometry
> Issue Type: New Feature
> Components: euclidean1D
> Reporter: Dimitrios Efthymiou
> Priority: Minor
> Labels: features
> Fix For: 1.1
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> implement isCodirectionalTo(Vector y) method in the Vector interface. The
> isCodirectionalTo() checks if the 2 vectors point at the same direction. This
> means that each vector can be obtained from the other by multiplying by a
> positive scalar.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
