psteitz commented on PR #231: URL: https://github.com/apache/commons-pool/pull/231#issuecomment-1636926034
Remembering now that we provide stats caching for timing metrics, I think it is reasonable to ask for that for active and idle counts. I take back my grumpiness above. I would be happy to review a PR to add activeCounts and idleCounts to go along with activeTimes and the other latency StatsStore instances now in BaseGenericObjectPool. I would approach that by creating activeCounts and idleCounts as StatsStore instances in BGOP and updating them in updateStatsOnReturn and updateStatsOnBorrow, using current active and idle counts from the pool, Then include these stats in reports. And tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
