Gilles Sadowski created IMAGING-358:
---------------------------------------
Summary: "RationalNumer" class is "public"
Key: IMAGING-358
URL: https://issues.apache.org/jira/browse/IMAGING-358
Project: Commons Imaging
Issue Type: Wish
Components: imaging.common.*
Affects Versions: 1.0-alpha2
Reporter: Gilles Sadowski
Fix For: 1.0, 1.0-alpha3
As per its Javadoc, class
[{{RationalNumber}}|https://commons.apache.org/proper/commons-imaging/apidocs/org/apache/commons/imaging/common/RationalNumber.html]
is tuned to the requirements of the TIFF format while its name purports that
it's a general implementation of the "fraction" concept.
Which is it?
Do we want that utility to be part of [Imaging]'s public API (thus eliciting
support to application developers who might use it beyond its intended scope)?
A dependency on [[Numbers]'s "fraction"
module|https://commons.apache.org/proper/commons-numbers/commons-numbers-docs/apidocs/org/apache/commons/numbers/fraction/package-summary.html],
as proposed in IMAGING-309) would avoid the issue, and also consolidate
(and/or help find potential bugs in) [Numbers]'s implementation.
If that proposal is not accepted, {{RationalNumber}} should preferably be moved
to [Imaging]'s [{{internal}}
package|https://commons.apache.org/proper/commons-imaging/apidocs/org/apache/commons/imaging/internal/package-summary.html].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
