aherbert commented on PR #406: URL: https://github.com/apache/commons-collections/pull/406#issuecomment-1638300622
The functional changes are fine, i.e. expose some measure of the capacity of the counts. But without an exact use case I am not certain of how it would be used. I think this could do with some naming improvement. You cannot `get` values from a counting Bloom filter. So `getMaxValue` seems out of context. Plus no other docs in the class refer to a 'cell'. The filter always uses the term 'bit index'. Should this property instead reflect that it is the maximum count of the same bit index that can be added to the filter before the state is invalidated. So change to `getMaxCount` and document that it is the maximum count that can be held for any bit index. If this is exceeded then the filter is invalidated (see `#isValid`). Q. Is there a reference computation for an estimate of the number of items that can be added before saturating a bit index with a certain probability. It may be useful to point a reader in the direction of some calculations. Thus they can use the Shape and this property to get an estimate of capacity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
