[ 
https://issues.apache.org/jira/browse/COLLECTIONS-844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743827#comment-17743827
 ] 

Alex Herbert commented on COLLECTIONS-844:
------------------------------------------

The functional changes in the PR are fine, i.e. expose some measure of the 
capacity of the counts. But without an exact use case I am not certain of how 
it would be used by an API user. If this is simply to make the abstract test 
passable for other implementation then it does not add value to the API.

Q. Is there a reference computation for an estimate of the number of items that 
can be added before saturating a bit index with a certain probability. It may 
be useful to point a reader in the direction of some calculations. Thus they 
can use the Shape and this property to get an estimate of capacity before 
invalidation.

 

> Counting Bloom filter expects counts (cells) to be ints
> -------------------------------------------------------
>
>                 Key: COLLECTIONS-844
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-844
>             Project: Commons Collections
>          Issue Type: Improvement
>    Affects Versions: 4.5
>            Reporter: Claude Warren
>            Priority: Minor
>
> The AbstractCountingBloomFilterTest assumes that the Bloom filter is using an 
> int to track the counts.  Any implementation using a smaller storage size 
> will not be able to pass the test.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to