[
https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744759#comment-17744759
]
Andreas Goss edited comment on GEOMETRY-144 at 7/19/23 8:08 PM:
----------------------------------------------------------------
I created a pull request on the github project for my suggested change and
refactoring of the hull module. Adjusting the code took somehow longer than
expected. Please review the code and let me know what you think. As commented
earlier, I keep the {{ConvexHull}} interface for now as deleting it completely
changed the behavior slightly. Also i made a minor addition to the logic of the
Akl-Toussaint Heuristic for when ones wishes to include collinear points.
I moved all the necessary test to the euclidean packaged and adapted them to
the new api. Apart from that I didn't alter any behavior.
was (Author: JIRAUSER298841):
I created a pull request on the github project for my suggested change and
refactoring of the hull module. Adjusting the code took somehow longer than
expected. Please review the code and let me know what you think. As commented
earlier, I keep the {{ConvexHull}} interface for now as deleting it completely
changed the behavior slightly.
> Review API in "hull" module
> ---------------------------
>
> Key: GEOMETRY-144
> URL: https://issues.apache.org/jira/browse/GEOMETRY-144
> Project: Commons Geometry
> Issue Type: Task
> Reporter: Gilles Sadowski
> Assignee: Gilles Sadowski
> Priority: Minor
> Fix For: 1.1
>
>
> Review codes in the
> [{{commons-geometry-hull}}|https://gitbox.apache.org/repos/asf?p=commons-geometry.git;a=tree;f=commons-geometry-hull;hb=HEAD]
> module.
> (x) Minimize the public API
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
