kinow commented on code in PR #304:
URL: https://github.com/apache/commons-imaging/pull/304#discussion_r1269199173
##########
src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageParser.java:
##########
@@ -75,7 +75,7 @@ private Rectangle checkForSubImage(
// dimensions of the image that is being read. This method
// returns the sub-image specification, if any, and leaves
// further tests to the calling module.
- if (params.isSubImageSet()) {
+ if (params != null && params.isSubImageSet()) {
Review Comment:
Hadn't time to review properly, but it would be useful to check if the
method that calls this private method couldn't be updated instead, to avoid a
null object reaching here. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
