Marcono1234 commented on code in PR #306: URL: https://github.com/apache/commons-imaging/pull/306#discussion_r1271482842
########## src/test/java/org/apache/commons/imaging/test/TestResources.java: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.commons.imaging.test; + +import java.io.File; +import java.net.URI; +import java.net.URISyntaxException; +import java.net.URL; +import java.nio.file.Path; +import java.nio.file.Paths; + +/** + * Helper class which provides convenience methods for accessing test resources. + */ +public class TestResources { + private TestResources() { + } + + private static URI resourceUri(String path) { + URL url = TestResources.class.getResource(path); + if (url == null) { + throw new IllegalArgumentException("Resource does not exist: " + path); + } + try { + return url.toURI(); + } catch (URISyntaxException e) { + throw new IllegalArgumentException(e); + } + } + + /** + * Gets a {@link File} for a {@linkplain Class#getResource(String) resource path}. + */ + public static File fileResource(String path) { + return new File(resourceUri(path)); + } + + /** + * Gets a {@link Path} for a {@linkplain Class#getResource(String) resource path}. + */ + public static Path pathResource(String path) { Review Comment: I am not completely sure about those names; at least `fileResource` sounds a bit like it also verifies the resource is an existing file (and not a directory), which it doesn't. Maybe `resourceFile` and `resourcePath` would be better (or some other name)? What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
