orionlibs commented on code in PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#discussion_r1277342044
##########
src/main/java/org/apache/commons/lang3/math/NumberUtils.java:
##########
@@ -1776,7 +1773,7 @@ private static boolean withDecimalsParsing(final String
str, final int beginIdx)
if (decimalPoints > 1) {
return false;
}
- if (!isDecimalPoint && !Character.isDigit(str.charAt(i))) {
+ if (!isDecimalPoint && !Character.isDigit(str.charAt(i)) && !(i ==
str.length() - 1 && str.charAt(i) == '.')) {
Review Comment:
perhaps there could be another method that takes a Locale object. Otherwise,
I don't think the current parser should concern itself with it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
