JuditKnoll commented on code in PR #221:
URL: https://github.com/apache/commons-bcel/pull/221#discussion_r1288233929
##########
src/main/java/org/apache/bcel/generic/Type.java:
##########
@@ -365,6 +366,24 @@ public int hashCode() {
return type ^ signature.hashCode();
}
+ static String internalTypeNameToSignature(final String internalTypeName) {
+ if (StringUtils.isEmpty(internalTypeName) ||
StringUtils.equalsAny(internalTypeName, "B", "C", "D", "F", "I", "J", "S",
"Z")) {
+ return internalTypeName;
Review Comment:
Since none of the existing arrays could be reused here because of the
different values, the renaming should be in a separate PR, not in this one. In
the [JVM
specification](https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.3.2)
these short names are introduced as field descriptors, but that name may cause
some confusion with the field and it rather refers to the type of the fields.
As far as I can see, this particular "array" contains the primitive or base
types, but naming it is the privilege of the author.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
