DazzaL commented on PR #127: URL: https://github.com/apache/commons-net/pull/127#issuecomment-1674749212
This 3.9 behaviour also breaks all FTP servers that sit behind F5 load balancers when passive mode is used which this patch fixes too as the client tries to connect to the F5 address Vs the serving pool member (connection refused error or read timeouts occur). Having said that isn't the resultant code now odd? As 3.9 added this isIpAddressFromPassiveResponse but now it's now set from the passive response anyway (and not overwritten from the control channel anymore). The only difference is that this setting still acts as a control switch for enabling / disabling the nat workaround strategy behaviour. So is this switch now not redundant here? Also what was the purpose of the switch, ie what's the problem with trusting the servers reply that resulted in a breaking change in 3.9.0 anyway? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
