Claudenw commented on code in PR #406:
URL:
https://github.com/apache/commons-collections/pull/406#discussion_r1292800714
##########
src/main/java/org/apache/commons/collections4/bloomfilter/IndexFilter.java:
##########
@@ -72,7 +72,10 @@ public boolean test(final int number) {
if (number >= size) {
throw new IndexOutOfBoundsException(String.format("number too
large %d >= %d", number, size));
}
- return !tracker.test(number) || consumer.test(number);
+ if (tracker.test(number)) {
Review Comment:
This change fixes code coverage check. In the original case there are 4
branches, one of which can not be tested. In this case there are only 3 and
the code coverage report shows 100% coverage for the Bloomfilter code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
