theshoeshiner commented on PR #1095: URL: https://github.com/apache/commons-lang/pull/1095#issuecomment-1677580047
@aherbert > This cannot parse standard floating point numbers generated by String valueOf as the exponent character in that case is E. > What if the exponent is negative? > What if the number is negative? > What if either number or exponent have an explicit + sign? All good points. Code should be fixed to handle all of these successfully. Although an explicit '+' might debatably be an error case, I would think it's better to handle it and document that it's allowed. > What if the number has more than 1 decimal point? Code should be fixed to fail on this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
