shashankrnr32 commented on code in PR #1086:
URL: https://github.com/apache/commons-lang/pull/1086#discussion_r1294890673
##########
src/main/java/org/apache/commons/lang3/builder/ReflectionToStringBuilder.java:
##########
@@ -703,13 +703,11 @@ public Class<?> getUpToClass() {
*
* @throws IllegalArgumentException
* see {@link java.lang.reflect.Field#get(Object)}
- * @throws IllegalAccessException
- * see {@link java.lang.reflect.Field#get(Object)}
*
* @see java.lang.reflect.Field#get(Object)
*/
- protected Object getValue(final Field field) throws IllegalAccessException
{
Review Comment:
As such, the method `Reflection.getUnchecked` does not throw any checked
exception. By keeping this, i would either have to rethrow that in
`appendFieldsIn` method or throw some `RuntimeException` so that i dont have to
add checked exceptions to all the methods.
So, I removed it here. Open to suggestions
1. Catch IllegalAccessException in the method `appendFieldsIn` and throw
some RuntimeException
2. Or rethrow the same exception. (Dont think this should be opted anyways)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
