garydgregory commented on code in PR #1086:
URL: https://github.com/apache/commons-lang/pull/1086#discussion_r1306651429
##########
src/main/java/org/apache/commons/lang3/builder/ReflectionToStringBuilder.java:
##########
@@ -703,13 +703,11 @@ public Class<?> getUpToClass() {
*
* @throws IllegalArgumentException
* see {@link java.lang.reflect.Field#get(Object)}
- * @throws IllegalAccessException
- * see {@link java.lang.reflect.Field#get(Object)}
*
* @see java.lang.reflect.Field#get(Object)
*/
- protected Object getValue(final Field field) throws IllegalAccessException
{
Review Comment:
Hello @shashankrnr32
Thank you for your update.
This PR attempts to restore compatibility with the `getValue()` method but
changes that method's definition and breaks compatibility differently. For
example, if I have a subclass that overrides `getValue()` using the released
signature, that subclass will no longer compile if this patch is applied. The
test in this PR does not reflect that a subclass can throw
`IllegalAccessException` in the `getValue()` method signature, so the test is
not checking for full compatibility. See git master for a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
