[ 
https://issues.apache.org/jira/browse/LANG-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759350#comment-17759350
 ] 

Gary D. Gregory commented on LANG-1710:
---------------------------------------

{quote}It is great that PR already created, but when it will be merged?
{quote}
A fix is now in git master and snapshot builds 
(https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-lang3/3.14.0-SNAPSHOT/).
 Please verify and close this ticket if this addresses your use case.
{quote}And what the release date?
{quote}
This is no planned release date at this time. I plan on releasing again 'soon', 
so probably within a month or so.
{quote}Also, Gary D. Gregory what do you think about using trySetAccessible 
instead of 
AccessibleObject.setAccessible(fields, true); and skipping not accessible 
fields?
{quote}
Feel free to provide a PR a GitHub so we can see exactly what this means.

> ReflectionToStringBuilder changes in version 3.13.0 has broken the logic for 
> overriding classes
> -----------------------------------------------------------------------------------------------
>
>                 Key: LANG-1710
>                 URL: https://issues.apache.org/jira/browse/LANG-1710
>             Project: Commons Lang
>          Issue Type: Bug
>            Reporter: Oksana
>            Priority: Major
>             Fix For: 3.14.0
>
>
> It is said that overriding classes should overload two methods:  
> _#getValue(java.lang.reflect.Field)}_ and 
> {_}#accept(java.lang.reflect.Field)}{_}.
> But since 3.13.0 getValue(java.lang.reflect.Field)} no longer called in 
> {_}appendFieldsIn{_}.
>  * System.out.println("An object: " + 
> ReflectionToStringBuilder.toString(anObject));
>  *  
>  * A subclass can control field output by overriding the methods:
>  *  
>  * <li>\{@link #accept(java.lang.reflect.Field)}</li>
>  * <li>\{@link #getValue(java.lang.reflect.Field)}</li>
> Also consider to use _trySetAccessible_ instead of 
> _AccessibleObject.setAccessible(fields, true);_ and skip not accessible 
> fields.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to