[
https://issues.apache.org/jira/browse/POOL-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855580#action_12855580
]
Sebb commented on POOL-155:
---------------------------
What about the specific case of the null object?
Would throwing an Exception break the contract?
I've worked on quite a few large systems where incorrect use of pool methods
caused intermittent problems at run-time.
It was usually very hard to track down the cause.
So I'm +1 on implementing checking (possibly optional) at some point.
> ObjectPool.invalidateObject(object) should throw an Exception if object is
> null
> -------------------------------------------------------------------------------
>
> Key: POOL-155
> URL: https://issues.apache.org/jira/browse/POOL-155
> Project: Commons Pool
> Issue Type: Improvement
> Affects Versions: 1.0, 1.0.1, 1.1, 1.2, 1.3, 1.4, 1.5, 1.5.1, 1.5.2,
> 1.5.3, 1.5.4
> Reporter: Sebb
> Fix For: 1.5.5
>
>
> ObjectPool.invalidateObject(object) should throw an Exception if object is
> null, otherwise the numActive count can get out of synch.
> It's easy to do this by mistake, see:
> http://markmail.org/thread/ya22ihmghejbfzme
> Also, the documentation for ObjectPool needs to be updated to clarify that
> invalidateObject should only be called if the object failed, not the borrow.
> [I'll do this shortly]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
