[
https://issues.apache.org/jira/browse/LOGGING-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Samael Bate updated LOGGING-185:
--------------------------------
Description:
mvn verify should be run as part of the build pipeline.
The integration tests are currently broken and I believe they have been since
[this PR|https://github.com/apache/commons-logging/pull/84] was merged because
it introduced static imports to {{org.junit.Assert}} which is not on the
classpath when running {_}mvn verify{_}.
There is also some incorrect config in the failsafe plugin.
By reverting the change to both ParentFirstTestCase.java and
SecurityForbiddenTestCase.java in that PR and fixing the pom I was able to
successfully run the tests.
was:
mvn verify should be run as part of the build pipeline.
The integration tests are currently broken and I believe they have been since
[this PR|https://github.com/apache/commons-logging/pull/84] was merged because
it introduced static imports to {{org.junit.Assert}} which is not on the
classpath when running {_}mvn verify{_}.
By reverting the change to both ParentFirstTestCase.java and
SecurityForbiddenTestCase.java in that PR I was able to successfully run the
tests.
> mvn verify should also be run as part of the github actions workflow
> --------------------------------------------------------------------
>
> Key: LOGGING-185
> URL: https://issues.apache.org/jira/browse/LOGGING-185
> Project: Commons Logging
> Issue Type: Improvement
> Reporter: Samael Bate
> Priority: Major
>
> mvn verify should be run as part of the build pipeline.
> The integration tests are currently broken and I believe they have been since
> [this PR|https://github.com/apache/commons-logging/pull/84] was merged
> because it introduced static imports to {{org.junit.Assert}} which is not on
> the classpath when running {_}mvn verify{_}.
> There is also some incorrect config in the failsafe plugin.
> By reverting the change to both ParentFirstTestCase.java and
> SecurityForbiddenTestCase.java in that PR and fixing the pom I was able to
> successfully run the tests.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
