[
https://issues.apache.org/jira/browse/POOL-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855584#action_12855584
]
Sebb commented on POOL-156:
---------------------------
I think this was fixed by:
URL: http://svn.apache.org/viewvc?rev=925180&view=rev
Log:
Fix and expand failing OOME test case
Add consistent handling for Throwables that are normally swallowed including
always re-throwing certain Throwables
Changed paths:
M /commons/proper/pool/trunk/src/java/org/apache/commons/pool/PoolUtils.java
M
/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java
M
/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericObjectPool.java
M
/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/SoftReferenceObjectPool.java
M
/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/StackKeyedObjectPool.java
M
/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/StackObjectPool.java
M
/commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestSoftRefOutOfMemory.java
> ObjectPool classes can ignore Throwable
> ---------------------------------------
>
> Key: POOL-156
> URL: https://issues.apache.org/jira/browse/POOL-156
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: 1.0, 1.0.1, 1.1, 1.2, 1.3, 1.4, 1.5, 1.5.1, 1.5.2,
> 1.5.3, 1.5.4
> Reporter: Sebb
> Fix For: 1.5.5
>
>
> The ObjectPool classes catch and ignore Throwable in several places.
> Catching Throwable should be done rarely, if ever, and should never ignore
> ThreadDeath.
> Indeed, ignoring Error is not normally advisable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
