aherbert commented on code in PR #157:
URL: https://github.com/apache/commons-logging/pull/157#discussion_r1313827241
##########
.github/workflows/maven.yml:
##########
@@ -35,18 +35,20 @@ jobs:
steps:
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
- with:
- persist-credentials: false
+ with:
+ persist-credentials: false
Review Comment:
Quite a few of them already do. Both Sebb and I collectively have added it
to many of the repos. E.g. it is present in lang, numbers, statistics, math,
geometry, now logging. It is not in text or imaging. It is very easy to add but
caution must be applied if the repo has binary files. These can be added as
exceptions to the attribute file. Imaging has binary image files that may
require an exclusion (the auto detection is quite good).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
