garydgregory commented on code in PR #157:
URL: https://github.com/apache/commons-logging/pull/157#discussion_r1313882636
##########
src/test/java/org/apache/commons/logging/pathable/ParentFirstTestCase.java:
##########
@@ -145,8 +143,9 @@ public void testPaths() throws Exception {
// (context, child, parent).
final ClassLoader systemLoader = ClassLoader.getSystemClassLoader();
assertNotNull("System classloader is null", systemLoader);
- assertNotEquals("System classloader has unexpected type",
PathableClassLoader.class.getName(),
- systemLoader.getClass().getName());
+ assertFalse("System classloader has unexpected type",
Review Comment:
What's the difference?
##########
src/test/java/org/apache/commons/logging/security/SecurityForbiddenTestCase.java:
##########
@@ -127,8 +125,8 @@ public void testAllForbidden() {
final Object factoryTable = factoryField.get(null);
assertNotNull(factoryTable);
final String ftClassName = factoryTable.getClass().getName();
- assertNotEquals("Custom hashtable unexpectedly used",
- CustomHashtable.class.getName(), ftClassName);
+ assertFalse("Custom hashtable unexpectedly used",
Review Comment:
What's the difference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
