SingingBush commented on code in PR #157:
URL: https://github.com/apache/commons-logging/pull/157#discussion_r1313942189
##########
src/test/java/org/apache/commons/logging/pathable/ParentFirstTestCase.java:
##########
@@ -145,8 +143,9 @@ public void testPaths() throws Exception {
// (context, child, parent).
final ClassLoader systemLoader = ClassLoader.getSystemClassLoader();
assertNotNull("System classloader is null", systemLoader);
- assertNotEquals("System classloader has unexpected type",
PathableClassLoader.class.getName(),
- systemLoader.getClass().getName());
+ assertFalse("System classloader has unexpected type",
Review Comment:
in junit 4 _assertTrue_ is part of TestCase and is available when the tests
are running. _assertNotEquals_ was coming from a static import of
`org.junit.Assert` which was getting a class not fund exception. It could be
changed to _assertNotSame_ as that's also part of the TestCase class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
