theshoeshiner commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1321548812
########## src/main/java/org/apache/commons/text/cases/CamelCase.java: ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.text.cases; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.commons.lang3.CharUtils; +import org.apache.commons.lang3.StringUtils; + +/** + * Case implementation that parses and formats strings of the form 'myCamelCase' + * <p> + * This case separates tokens on uppercase ASCII alpha characters. Each token begins with an Review Comment: If you're talking about the logic of dividing tokens, my understanding is that the uppercase/lowercase distinction, which is inherently necessary for proper camelCase, is a quirk of the Latin languages. If a similar distinction is present in other languages that require unicode characters then I suppose this class could be broken into two classes - a base class that accepts character ranges and then concrete classes that provide them. This would allow users to implement a Case that works like camelCase but divides the tokens based on some other character range. But as far as camelCase specifically, I think it makes sense to stick to the accepted definition. To my surprise, [many modern languages support unicode identifiers](https://rosettacode.org/wiki/Unicode_variable_names). Which means we'd definitely want to continue to handle unicode for Case implementations that dont depend on upper/lower case characters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
